Skip to main content

[CHD-1367] - Incomplete - [Parser] There isn't enough error checking before the unlink() call to trap all failing mail

In Fix Branch: 
Yes
Jira
Jira Status: 
In Wish List Hell
GitHub Branches

Most of it is outlined in this forum post.

http://forums.cerb4.com/showthread.php?t=2270

The simple issues is that function _parseFile($full_filename) { doesn't check for error before calling @unlink($full_filename); so the file gets deleted no mater what and only moved to failed if you have code in place to trap a certain error. I see several errors that could result in the lose of emails. At a min that function needs updated with code to check for errors and move the to fail instead of removing it on fail.

Thanks
Robert

The current patch simple leave the mail there and doesn't delete it. It also breaks bounces / discards as well. I need to create a proper fix for this at some point.

AttachmentSize
cerb4-chd-1367.patch658 bytes
cerb5-chd-1367.patch658 bytes

Post new comment

The content of this field is kept private and will not be shown publicly.
  • Web page addresses and e-mail addresses turn into links automatically.
  • Allowed HTML tags: <a> <em> <strong> <cite> <code> <ul> <ol> <li> <dl> <dt> <dd>
  • Lines and paragraphs break automatically.
  • You may post code using <code>...</code> (generic) or <?php ... ?> (highlighted PHP) tags.
  • Glossary terms will be automatically marked with links to their descriptions. If there are certain phrases or sections of text that should be excluded from glossary marking and linking, use the special markup, [no-glossary] ... [/no-glossary]. Additionally, these HTML elements will not be scanned: a, abbr, acronym, code, pre.
  • Project issue numbers (ex. [#12345]) turn into links automatically.

More information about formatting options

By submitting this form, you accept the Mollom privacy policy.