[CHD-1367] - Incomplete - [Parser] There isn't enough error checking before the unlink() call to trap all failing mail
Most of it is outlined in this forum post.
http://forums.cerb4.com/showthread.php?t=2270
The simple issues is that function _parseFile($full_filename) { doesn't check for error before calling @unlink($full_filename); so the file gets deleted no mater what and only moved to failed if you have code in place to trap a certain error. I see several errors that could result in the lose of emails. At a min that function needs updated with code to check for errors and move the to fail instead of removing it on fail.
Thanks
Robert
The current patch simple leave the mail there and doesn't delete it. It also breaks bounces / discards as well. I need to create a proper fix for this at some point.
| Attachment | Size |
|---|---|
| cerb4-chd-1367.patch | 658 bytes |
| cerb5-chd-1367.patch | 658 bytes |
Post new comment